feat(ui,clerk-js,shared): Add <experimental_ConfigureSSO />#8427
Open
LauraBeatris wants to merge 13 commits intomainfrom
Open
feat(ui,clerk-js,shared): Add <experimental_ConfigureSSO />#8427LauraBeatris wants to merge 13 commits intomainfrom
<experimental_ConfigureSSO />#8427LauraBeatris wants to merge 13 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bcc4254 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
clerk-js
nextjs
react
localizations
chrome-extension
tanstack
astro
react-router
nuxt
vue
ui
labels
LauraBeatris
changed the title
<ConfigureSSO /><ConfigureSSO />
LauraBeatris
changed the title
<ConfigureSSO /><experimental_ConfigureSSO />
LauraBeatris
changed the title
<experimental_ConfigureSSO /> <experimental_ConfigureSSO />
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
d206a33 to
317f492
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
0be1d49 to
1f1c9d9
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
ebcac3f to
4a5c44e
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
4a5c44e to
49e435e
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
aca3fac to
7b91453
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/react/src/isomorphicClerk.ts (1)
4-41:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winRemove duplicate
OAuthConsentPropsimport to fix TypeScript compilation.
OAuthConsentPropsis imported twice in the sameimport typeclause. Remove the duplicate to prevent TypeScript errors.Suggested fix
import type { __internal_AttemptToEnableEnvironmentSettingParams, __internal_AttemptToEnableEnvironmentSettingResult, __internal_CheckoutProps, __internal_EnableOrganizationsPromptProps, - OAuthConsentProps, __internal_PlanDetailsProps, __internal_SubscriptionDetailsProps, __internal_UserVerificationModalProps, __internal_UserVerificationProps, APIKeysNamespace, @@ LoadedClerk, OAuthApplicationNamespace, OAuthConsentProps, OrganizationListProps,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/react/src/isomorphicClerk.ts` around lines 4 - 41, The import list in the top-level type import contains a duplicate symbol OAuthConsentProps which causes TypeScript to fail; edit the import type clause that declares OAuthConsentProps (in isomorphicClerk.ts) and remove the redundant OAuthConsentProps entry so the symbol is only imported once, preserving the rest of the imported names like LoadedClerk, ClerkOptions, and ListenerCallback.
♻️ Duplicate comments (1)
packages/ui/src/components/ConfigureSSO/__tests__/ConfigureSSO.test.tsx (1)
16-19:⚠️ Potential issue | 🟠 Major | ⚡ Quick winTest fixture masks the
self_serve_ssogating path.At Line 17, setting
enterpriseSSO.enabled = falseallows this test to pass even if theself_serve_ssoguard is broken. Keep enterprise SSO enabled and only disableself_serve_ssoso this test validates the intended branch.Suggested fix
- fixtures.environment.userSettings.enterpriseSSO = { - enabled: false, - self_serve_sso: false, - }; + fixtures.environment.userSettings.enterpriseSSO = { + enabled: true, + self_serve_sso: false, + };As per coding guidelines, "Use proper test coverage in React component tests" and "Test component behavior, not implementation details."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ui/src/components/ConfigureSSO/__tests__/ConfigureSSO.test.tsx` around lines 16 - 19, The test fixture currently disables the entire enterprise SSO gate (fixtures.environment.userSettings.enterpriseSSO.enabled = false) which masks the self_serve_sso branch; change the fixture so enterpriseSSO.enabled remains true and only set enterpriseSSO.self_serve_sso = false, then update the ConfigureSSO test to assert the component behavior that corresponds to the self-serve-disabled path (using the existing test assertions for ConfigureSSO rendering) so the test validates the intended branch guarded by self_serve_sso.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/react/src/isomorphicClerk.ts`:
- Around line 4-41: The import list in the top-level type import contains a
duplicate symbol OAuthConsentProps which causes TypeScript to fail; edit the
import type clause that declares OAuthConsentProps (in isomorphicClerk.ts) and
remove the redundant OAuthConsentProps entry so the symbol is only imported
once, preserving the rest of the imported names like LoadedClerk, ClerkOptions,
and ListenerCallback.
---
Duplicate comments:
In `@packages/ui/src/components/ConfigureSSO/__tests__/ConfigureSSO.test.tsx`:
- Around line 16-19: The test fixture currently disables the entire enterprise
SSO gate (fixtures.environment.userSettings.enterpriseSSO.enabled = false) which
masks the self_serve_sso branch; change the fixture so enterpriseSSO.enabled
remains true and only set enterpriseSSO.self_serve_sso = false, then update the
ConfigureSSO test to assert the component behavior that corresponds to the
self-serve-disabled path (using the existing test assertions for ConfigureSSO
rendering) so the test validates the intended branch guarded by self_serve_sso.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5a88c1b9-f51a-4e1c-a9c0-6b3d3ca192c2
📒 Files selected for processing (80)
.changeset/thirty-candies-lick.mdpackages/astro/src/astro-components/index.tspackages/astro/src/astro-components/interactive/ConfigureSSO.astropackages/astro/src/internal/mount-clerk-astro-js-components.tspackages/astro/src/types.tspackages/clerk-js/sandbox/app.tspackages/clerk-js/sandbox/template.htmlpackages/clerk-js/src/core/clerk.tspackages/clerk-js/src/core/resources/UserSettings.tspackages/clerk-js/src/test/fixture-helpers.tspackages/localizations/src/ar-SA.tspackages/localizations/src/be-BY.tspackages/localizations/src/bg-BG.tspackages/localizations/src/bn-IN.tspackages/localizations/src/ca-ES.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/da-DK.tspackages/localizations/src/de-DE.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-GB.tspackages/localizations/src/en-US.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-UY.tspackages/localizations/src/fa-IR.tspackages/localizations/src/fi-FI.tspackages/localizations/src/fr-FR.tspackages/localizations/src/he-IL.tspackages/localizations/src/hi-IN.tspackages/localizations/src/hr-HR.tspackages/localizations/src/hu-HU.tspackages/localizations/src/id-ID.tspackages/localizations/src/is-IS.tspackages/localizations/src/it-IT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/ko-KR.tspackages/localizations/src/mn-MN.tspackages/localizations/src/ms-MY.tspackages/localizations/src/nb-NO.tspackages/localizations/src/nl-BE.tspackages/localizations/src/nl-NL.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ro-RO.tspackages/localizations/src/ru-RU.tspackages/localizations/src/sk-SK.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ta-IN.tspackages/localizations/src/te-IN.tspackages/localizations/src/th-TH.tspackages/localizations/src/tr-TR.tspackages/localizations/src/uk-UA.tspackages/localizations/src/vi-VN.tspackages/localizations/src/zh-CN.tspackages/localizations/src/zh-TW.tspackages/nuxt/src/module.tspackages/react/src/components/uiComponents.tsxpackages/react/src/experimental.tspackages/react/src/isomorphicClerk.tspackages/shared/src/internal/clerk-js/componentGuards.tspackages/shared/src/internal/clerk-js/warnings.tspackages/shared/src/types/clerk.tspackages/shared/src/types/localization.tspackages/shared/src/types/userSettings.tspackages/ui/src/components/ConfigureSSO/ConfigureSSO.tsxpackages/ui/src/components/ConfigureSSO/__tests__/ConfigureSSO.test.tsxpackages/ui/src/contexts/ClerkUIComponentsContext.tsxpackages/ui/src/contexts/components/ConfigureSSO.tspackages/ui/src/contexts/components/index.tspackages/ui/src/elements/Navbar.tsxpackages/ui/src/elements/contexts/index.tsxpackages/ui/src/internal/appearance.tspackages/ui/src/lazyModules/components.tspackages/ui/src/types.tspackages/vue/src/components/ui-components/ConfigureSSO.vuepackages/vue/src/experimental.ts
✅ Files skipped from review due to trivial changes (59)
- packages/localizations/src/es-UY.ts
- packages/ui/src/elements/contexts/index.tsx
- packages/ui/src/contexts/components/index.ts
- packages/localizations/src/pt-PT.ts
- .changeset/thirty-candies-lick.md
- packages/astro/src/astro-components/index.ts
- packages/localizations/src/es-ES.ts
- packages/vue/src/components/ui-components/ConfigureSSO.vue
- packages/clerk-js/sandbox/template.html
- packages/localizations/src/be-BY.ts
- packages/localizations/src/mn-MN.ts
- packages/localizations/src/sk-SK.ts
- packages/localizations/src/tr-TR.ts
- packages/astro/src/astro-components/interactive/ConfigureSSO.astro
- packages/localizations/src/nl-NL.ts
- packages/localizations/src/is-IS.ts
- packages/localizations/src/ta-IN.ts
- packages/astro/src/internal/mount-clerk-astro-js-components.ts
- packages/shared/src/internal/clerk-js/warnings.ts
- packages/localizations/src/hr-HR.ts
- packages/localizations/src/cs-CZ.ts
- packages/localizations/src/nb-NO.ts
- packages/localizations/src/ca-ES.ts
- packages/localizations/src/fr-FR.ts
- packages/localizations/src/fi-FI.ts
- packages/localizations/src/da-DK.ts
- packages/localizations/src/te-IN.ts
- packages/localizations/src/en-GB.ts
- packages/localizations/src/hi-IN.ts
- packages/react/src/experimental.ts
- packages/localizations/src/pt-BR.ts
- packages/localizations/src/ar-SA.ts
- packages/clerk-js/src/test/fixture-helpers.ts
- packages/localizations/src/ro-RO.ts
- packages/localizations/src/bn-IN.ts
- packages/localizations/src/kk-KZ.ts
- packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx
- packages/clerk-js/src/core/resources/UserSettings.ts
- packages/astro/src/types.ts
- packages/localizations/src/ko-KR.ts
- packages/localizations/src/es-MX.ts
- packages/localizations/src/el-GR.ts
- packages/localizations/src/ru-RU.ts
- packages/localizations/src/bg-BG.ts
- packages/localizations/src/it-IT.ts
- packages/localizations/src/pl-PL.ts
- packages/localizations/src/id-ID.ts
- packages/localizations/src/zh-TW.ts
- packages/localizations/src/ms-MY.ts
- packages/localizations/src/sv-SE.ts
- packages/localizations/src/ja-JP.ts
- packages/localizations/src/vi-VN.ts
- packages/localizations/src/zh-CN.ts
- packages/localizations/src/en-US.ts
- packages/localizations/src/fa-IR.ts
- packages/localizations/src/uk-UA.ts
- packages/localizations/src/nl-BE.ts
- packages/ui/src/elements/Navbar.tsx
- packages/shared/src/types/localization.ts
🚧 Files skipped from review as they are similar to previous changes (13)
- packages/localizations/src/sr-RS.ts
- packages/nuxt/src/module.ts
- packages/shared/src/types/userSettings.ts
- packages/ui/src/internal/appearance.ts
- packages/localizations/src/th-TH.ts
- packages/ui/src/contexts/components/ConfigureSSO.ts
- packages/localizations/src/he-IL.ts
- packages/localizations/src/es-CR.ts
- packages/localizations/src/de-DE.ts
- packages/clerk-js/sandbox/app.ts
- packages/shared/src/internal/clerk-js/componentGuards.ts
- packages/react/src/components/uiComponents.tsx
- packages/vue/src/experimental.ts
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
bd8b697 to
1949c6d
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
2 times, most recently
from
45b678b to
606d652
Compare
LauraBeatris
force-pushed
the
laura/add-configure-sso-component
branch
from
606d652 to
b6cf956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the scaffolding structure for
<__experimental_ConfigureSSO />- it doesn't include actual functionally + UI content yet, this will be introduced in a separate PR.The goal is to get the initial structure merged here (clerk/ui methods, packages exports, etc) merged, so the next UI PRs are easier to parallelize + easier to review.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change